• Joined on 2026-03-17
marcel merged pull request marcel/familienarchiv#331 2026-04-25 19:27:54 +02:00
feat: bulk metadata edit for existing documents
marcel closed issue marcel/familienarchiv#225 2026-04-25 19:27:54 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)
marcel pushed to main at marcel/familienarchiv 2026-04-25 19:27:54 +02:00
c59287fcfc fix(bulk-edit): cycle-3 polish — Felix C2/C3/C4/C5 + Sara coverage gaps
8ce96294b0 fix(bulk-edit): cycle-2 blockers — restore initial-* props, missing import, scope Esc, edit-mode topbar
1803db86b5 test(bulk-edit): plug Sara's identified coverage gaps
46001bbf9d refactor(documents): extract buildSearchSpec and resolveTags helpers
af8303dbf8 fix(bulk-edit): auto-clear selection store when leaving /documents and /enrich
Compare 23 commits »
marcel commented on pull request marcel/familienarchiv#331 2026-04-25 19:26:00 +02:00
feat: bulk metadata edit for existing documents

Cycle 4 — all 7 personas approved

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 19:24:58 +02:00
feat: bulk metadata edit for existing documents

🧪 Sara Holt — QA Engineer & Test Strategist — Cycle 4

Verdict: Approved

Three of the five gaps I flagged in cycle 3 are now closed with named, focused regression fences. The…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 19:24:55 +02:00
feat: bulk metadata edit for existing documents

👨‍💻 Felix Brandt — Senior Fullstack Developer — Cycle 4

Verdict: Approved

Cycle 3 closed every concern I raised in cycle 2 (C2/C3/C4/C5) cleanly, and the regression tests Sara and…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 19:23:21 +02:00
feat: bulk metadata edit for existing documents

🔐 Nora "NullX" Steiner — Application Security Engineer — Cycle 4

Verdict: Approved

Cycle 3 is purely defence-hardening on top of an already-clean security posture. Both items I…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 19:23:14 +02:00
feat: bulk metadata edit for existing documents

📋 Elicit — Requirements Engineer — Cycle 4

Verdict: Approved

Cycle 3 commit c59287fc is pure polish + test coverage. No AC-touching code paths altered, no new ambiguity introduced,…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 19:23:09 +02:00
feat: bulk metadata edit for existing documents

🎨 Leonie Voss — UX Designer & Accessibility Strategist — Cycle 4

Verdict: Approved — LGTM

Quick re-pass to confirm the cycle-3 follow-up (N1) landed. It did, and then some.

N1…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 19:22:57 +02:00
feat: bulk metadata edit for existing documents

🏗️ Markus Keller — Senior Application Architect — Cycle 4

Verdict: Approved

Cycle-3 commit c59287fc is exactly the kind of polish I want at the end of a multi-cycle PR — three…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 19:21:55 +02:00
feat: bulk metadata edit for existing documents

🛠️ Tobias Wendt — DevOps & Platform Engineer — Cycle 4

Verdict: Approved

Cycle-3 commit c59287fc is exactly the kind of polish I want to see late in a review loop: tightened…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 19:20:20 +02:00
feat: bulk metadata edit for existing documents

Cycle 3 fixes pushed (commit c59287fc)

Felix's 5 lingering concerns from cycle 2 + Sara's test-coverage gaps:

  • Felix C2BatchMetadataRequest controller now uses @Valid. -…
marcel pushed to feat/issue-225-bulk-metadata-edit at marcel/familienarchiv 2026-04-25 19:19:55 +02:00
c59287fcfc fix(bulk-edit): cycle-3 polish — Felix C2/C3/C4/C5 + Sara coverage gaps
marcel commented on pull request marcel/familienarchiv#331 2026-04-25 17:24:17 +02:00
feat: bulk metadata edit for existing documents

👨‍💻 Felix Brandt — Senior Fullstack Developer — Cycle 3

Verdict: ⚠️ Approved with concerns

Both my cycle-2 blockers are properly resolved. The B1 regression fix is the right shape —…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 17:24:01 +02:00
feat: bulk metadata edit for existing documents

🧪 Sara Holt — QA Engineer & Test Strategist — Cycle 3

Verdict: ⚠️ Approved with concerns

The two test gaps I asked for in cycle 2 are both plugged with the right shape. `patchBulk_stri…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 17:22:54 +02:00
feat: bulk metadata edit for existing documents

🎨 Leonie Voss — UX Designer & Accessibility Strategist — Cycle 3

Verdict: Approved

Both cycle-2 blockers landed cleanly. B5 is the literal one-line import in `frontend/src/routes/enr…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 17:22:45 +02:00
feat: bulk metadata edit for existing documents

🏗️ Markus Keller — Senior Application Architect — Cycle 3

Verdict: Approved

Cycle-2 fixes land cleanly. The data-loss regression on /documents/[id]/edit is properly resolved by…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 17:22:19 +02:00
feat: bulk metadata edit for existing documents

🔐 Nora "NullX" Steiner — Application Security Engineer — Cycle 3

Verdict: Approved

Re-audited every cycle-2 delta with a fresh adversarial pass. No new attack surface, no regressions…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 17:21:58 +02:00
feat: bulk metadata edit for existing documents

📋 Elicit — Requirements Engineer — Cycle 3

Verdict: Approved

C1 — the only persisting concern from cycle 2 — is now properly fixed. Every AC from issue #225's Bulk-Edit Panel

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 17:21:11 +02:00
feat: bulk metadata edit for existing documents

🛠️ Tobias Wendt — DevOps & Platform Engineer — Cycle 3

Verdict: Approved

Cycle-2 commit 8ce96294 is purely Felix/Leonie/Elicit/Sara fixes — frontend props, an enrich import, an…