• Joined on 2026-03-17
marcel deleted branch feat/issue-628-mention-reedit from marcel/familienarchiv 2026-06-03 07:55:34 +02:00
marcel pushed to main at marcel/familienarchiv 2026-06-03 07:55:31 +02:00
7d37e610da test(frontend): exclude mentionNodeView from server coverage (#628)
9c1eb7608b fix(transcription): harden re-edit pencil hit-testing + disable sync (#628 review)
9bba5e4a7a feat(transcription): announce re-edit context via the existing live region (#628)
751a48b22c test(transcription): AC-7 disabled, AC-8 no-mention, security clip/provenance (#628)
58a30a6e2e test(transcription): AC-6 single-dropdown invariant + stale-fetch guard (#628)
Compare 9 commits »
marcel closed issue marcel/familienarchiv#628 2026-06-03 07:55:30 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input
marcel merged pull request marcel/familienarchiv#717 2026-06-03 07:55:30 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)
marcel pushed to feat/issue-716-remove-briefwechsel at marcel/familienarchiv 2026-06-03 07:53:31 +02:00
ed7b19fac0 docs(e2e): fix stale spec listing after Briefwechsel removal
marcel pushed to feat/issue-560-shared-vimock-mocks at marcel/familienarchiv 2026-06-03 07:52:58 +02:00
f13999d006 fix(test): load shared mocks via vi.hoisted, not a static import
marcel commented on pull request marcel/familienarchiv#721 2026-06-03 07:52:06 +02:00
feat: Remove the Briefwechsel view; retarget its links to document search (#716)

🎨 Leonie Voss — UI/UX Design Lead & Accessibility Strategist

Verdict: ⚠️ Approved with concerns

The whole UI surface of this PR is one card — the "Häufige Korrespondenten" chip — so…

marcel commented on pull request marcel/familienarchiv#721 2026-06-03 07:51:44 +02:00
feat: Remove the Briefwechsel view; retarget its links to document search (#716)

📋 "Elicit" — Requirements Engineer & Business Analyst

Verdict: ⚠️ Approved with concerns

I assessed this against the issue #716 acceptance criteria (the stated single source of truth)…

marcel commented on pull request marcel/familienarchiv#721 2026-06-03 07:51:30 +02:00
feat: Remove the Briefwechsel view; retarget its links to document search (#716)

🔧 Tobias Lange — DevOps Engineer

Verdict: Approved (LGTM)

I checked this for infrastructure impact: Compose services, CI workflow, reverse-proxy/Caddy config, secrets, migrations,…

marcel commented on pull request marcel/familienarchiv#721 2026-06-03 07:51:17 +02:00
feat: Remove the Briefwechsel view; retarget its links to document search (#716)

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

I care about one thing above all on a removal: the acceptance criteria each have a test that actually executes,…

marcel commented on pull request marcel/familienarchiv#721 2026-06-03 07:51:01 +02:00
feat: Remove the Briefwechsel view; retarget its links to document search (#716)

🛡️ Nora Steiner ("NullX") — Application Security Engineer

Verdict: Approved

A feature removal is mostly attack-surface reduction, so my job here is to confirm nothing was opened up…

marcel commented on pull request marcel/familienarchiv#721 2026-06-03 07:50:44 +02:00
feat: Remove the Briefwechsel view; retarget its links to document search (#716)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: Approved

This is a clean deletion-heavy PR (5433 lines out, 137 in). I focused on the code that survives — the retargeted…

marcel commented on pull request marcel/familienarchiv#721 2026-06-03 07:50:31 +02:00
feat: Remove the Briefwechsel view; retarget its links to document search (#716)

🏛️ Markus Keller — Senior Application Architect

Verdict: ⚠️ Approved with concerns

I reviewed this as a clean, grep-driven feature removal: does the dead code go away completely, do…

marcel commented on pull request marcel/familienarchiv#720 2026-06-03 07:47:34 +02:00
fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

The fix is small, correct, and the two tests are genuinely good. They assert user-visible behavior

marcel commented on pull request marcel/familienarchiv#720 2026-06-03 07:47:30 +02:00
fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)

🎨 Leonie Voss — UI/UX Design Lead & Accessibility Advocate

Verdict: Approved

I reviewed this purely through the accessibility lens it claims to fix, and it lands cleanly. The a11y…

marcel commented on pull request marcel/familienarchiv#719 2026-06-02 20:55:16 +02:00
Consolidate shared vi.mock bodies + migrate confirm/notification specs (#560)

👨‍💻 Felix Brandt — Senior Fullstack Developer

⚠️ Approved with concerns — clean, well-factored dedup with real TDD evidence (the no-factory ban is genuine red→green). The shared-mock…

marcel commented on pull request marcel/familienarchiv#719 2026-06-02 20:55:12 +02:00
Consolidate shared vi.mock bodies + migrate confirm/notification specs (#560)

🎨 Leonie Voss — UX / Accessibility Review

⚠️ Solid a11y assertions, but the "single" case has a tautology gap and the error state deserves a second look.

This PR is overwhelmingly…

marcel commented on pull request marcel/familienarchiv#719 2026-06-02 20:55:12 +02:00
Consolidate shared vi.mock bodies + migrate confirm/notification specs (#560)

🏛️ Markus Keller (@mkeller) — Architect

⚠️ Approved with concerns — the context-provider design is sound and the SSE refcount semantics survive the refactor, but the production…

marcel commented on pull request marcel/familienarchiv#719 2026-06-02 20:55:03 +02:00
Consolidate shared vi.mock bodies + migrate confirm/notification specs (#560)

🔒 Nora "NullX" Steiner — Security

LGTM — no auth/session/redirect regression. This is a clean singleton→factory refactor; the security-relevant code paths are byte-for-byte…

marcel commented on pull request marcel/familienarchiv#720 2026-06-02 20:54:59 +02:00
fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

The fix is minimal and correct, and the two tests are real-DOM (vitest-browser-svelte), correctly…