marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on issue marcel/familienarchiv#225 2026-04-25 12:46:40 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

  • mode="edit" is a boolean flag in prop form. The issue specifies it as a single string enum ("upload" / "edit"),…
marcel commented on issue marcel/familienarchiv#225 2026-04-25 12:46:18 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

🏗️ Markus Keller — Senior Application Architect

Observations

  • mode="edit" on the existing BulkDocumentEditLayout is the right call. Avoids a second layout file and keeps the…
marcel created branch feat/issue-317-bulk-upload in marcel/familienarchiv 2026-04-25 12:29:01 +02:00
marcel pushed to feat/issue-317-bulk-upload at marcel/familienarchiv 2026-04-25 12:29:01 +02:00
50621f9a15 test(bulk-upload): add cancel-path coverage for discard-all confirm dialog
1fca1f80a2 docs(bulk-upload): explain chunkSize=10 and 50-file cap constants
46dae8a826 feat(bulk-upload): guard discard-all with confirm dialog
e5fe2fc5c6 fix(bulk-upload): add gradient overflow indicators to chip strip
0ab85d888b fix(bulk-upload): chip readability and focus management in FileSwitcherStrip
Compare 10 commits »
marcel pushed to main at marcel/familienarchiv 2026-04-25 12:24:28 +02:00
0797406f02 docs(bulk-upload): explain chunkSize=10 and 50-file cap constants
c94d2cec03 feat(bulk-upload): guard discard-all with confirm dialog
4da0bf71a0 fix(bulk-upload): add gradient overflow indicators to chip strip
da5d3c60b3 fix(bulk-upload): chip readability and focus management in FileSwitcherStrip
ed0d0bf331 fix(bulk-upload): handle network errors and partial upload success
Compare 46 commits »
marcel deleted branch feat/issue-317-bulk-upload from marcel/familienarchiv 2026-04-25 12:24:28 +02:00
marcel closed issue marcel/familienarchiv#317 2026-04-25 12:24:26 +02:00
feat(documents): bulk upload — split-panel with file switcher
marcel merged pull request marcel/familienarchiv#329 2026-04-25 12:24:26 +02:00
feat(documents): bulk upload — split-panel with file switcher
marcel deleted branch feat/issue-320-transcribe-coach from marcel/familienarchiv 2026-04-25 12:24:06 +02:00
marcel closed issue marcel/familienarchiv#320 2026-04-25 12:24:05 +02:00
feat(transcribe): guided empty state + Kurrent primer for first-time transcribers
marcel pushed to main at marcel/familienarchiv 2026-04-25 12:24:05 +02:00
48d034dcb8 fix(transcribe-coach): propagate hover from 44px button group to inner span
c335ddd686 test(e2e): add training footer positive-case test and fix broken selectors
7830a749a0 docs(richtlinien): shorten prerender comment to essentials
5b7c37391c test(HelpPopover): use userEvent.keyboard for Enter/Space tests
ce72b07197 test(e2e): fix locators, add print assertion, cleanup, remove redundant emulateMedia
Compare 13 commits »
marcel merged pull request marcel/familienarchiv#330 2026-04-25 12:24:04 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers
marcel commented on pull request marcel/familienarchiv#329 2026-04-25 12:06:16 +02:00
feat(documents): bulk upload — split-panel with file switcher

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

Accessibility fundamentals are solid. The component set is well-thought-out for the target audience…

marcel commented on pull request marcel/familienarchiv#329 2026-04-25 12:05:57 +02:00
feat(documents): bulk upload — split-panel with file switcher

📋 Elicit — Requirements Engineer

Verdict: ⚠️ Approved with concerns

The PR description is dense and well-structured. The implementation matches the stated intent. Two requirements…

marcel commented on pull request marcel/familienarchiv#329 2026-04-25 12:05:43 +02:00
feat(documents): bulk upload — split-panel with file switcher

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

No new infrastructure, no Compose changes, no CI changes — all good. One operational item needs…

marcel commented on pull request marcel/familienarchiv#329 2026-04-25 12:05:32 +02:00
feat(documents): bulk upload — split-panel with file switcher

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

Coverage is strong and the test pyramid is well-structured. A few gaps that would catch real bugs in…

marcel commented on pull request marcel/familienarchiv#329 2026-04-25 12:05:14 +02:00
feat(documents): bulk upload — split-panel with file switcher

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

No new attack surface introduced. Existing controls hold. One low-severity gap worth addressing in a…

marcel commented on pull request marcel/familienarchiv#329 2026-04-25 12:04:59 +02:00
feat(documents): bulk upload — split-panel with file switcher

🏗️ Markus Keller — Application Architect

Verdict: ✅ Approved

Architecture is clean. Monolith boundaries are respected, no new infrastructure, and the service layer correctly owns all…

marcel commented on pull request marcel/familienarchiv#329 2026-04-25 12:04:41 +02:00
feat(documents): bulk upload — split-panel with file switcher

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Solid feature. Clean separation across the stack, good use of Svelte 5 primitives, and test coverage…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 12:04:17 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

This is high-quality accessibility work. The HelpPopover and coach empty state both show care for the 60+…