marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#717 2026-06-02 20:14:24 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved (nothing in my domain)

Checked for anything operational and found none — as expected for a frontend feature PR.

  • No…
marcel commented on pull request marcel/familienarchiv#717 2026-06-02 20:14:19 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)

📋 Elicit — Requirements Engineer

Verdict: ✅ Approved

Traceability is clean — every acceptance criterion maps to at least one named test, and the one deviation is surfaced, not…

marcel commented on pull request marcel/familienarchiv#717 2026-06-02 20:14:06 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)

🎨 Leonie Voss — UX & Accessibility Lead

Verdict: ⚠️ Approved with concerns

The affordance respects the senior-first constraints I care about, and the a11y wiring is mostly textbook.…

marcel commented on pull request marcel/familienarchiv#717 2026-06-02 20:13:52 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

The suite is genuinely well-built — descriptive names, factory helpers, AAA, and the stale-fetch test is…

marcel commented on pull request marcel/familienarchiv#717 2026-06-02 20:13:34 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)

🛡️ Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

The user-influenced data paths are handled correctly, and there's a regression test for each. No new attack…

marcel commented on pull request marcel/familienarchiv#717 2026-06-02 20:13:25 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

Frontend-only, no module-boundary or transport implications. The judgment calls land where I'd put them.

What I…

marcel commented on pull request marcel/familienarchiv#717 2026-06-02 20:13:17 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

This is the structure I'd want. The single-controller refactor (createMentionController) is the right move — it…

marcel commented on pull request marcel/familienarchiv#717 2026-06-02 20:09:36 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)

Clean-agent review → fixes applied (commit a62a333d)

A fresh-eyes reviewer (no prior context) checked the diff against #628's ACs. Verdict: approve-with-nits, no blockers. Two real…

marcel pushed to feat/issue-628-mention-reedit at marcel/familienarchiv 2026-06-02 20:09:23 +02:00
a62a333d09 fix(transcription): harden re-edit pencil hit-testing + disable sync (#628 review)
marcel opened issue marcel/familienarchiv#718 2026-06-02 20:08:44 +02:00
[bug] Stammbaum keyboard tab order is unpredictable — follows DB order, not visual layout
marcel created pull request marcel/familienarchiv#717 2026-06-02 19:59:29 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)
marcel deleted branch feat/issue-603-composite-deploy-actions from marcel/familienarchiv 2026-06-02 19:57:22 +02:00
marcel pushed to main at marcel/familienarchiv 2026-06-02 19:57:21 +02:00
03e2615fa7 ci(deploy): use ::error:: annotations for smoke-test failures
3db6a3bf8f ci(deploy): correct stale POSTGRES_HOST --env-file comment
0e06626eef ci(deploy): guard deploy-obs heredoc stays unquoted (#603)
a47564934d ci(deploy): harden deploy-obs config step with set -euo pipefail
02fb16a0bd docs(ci): document composite actions in ci-gitea.md
Compare 12 commits »
marcel closed issue marcel/familienarchiv#603 2026-06-02 19:57:21 +02:00
devops: extract composite action for obs stack deploy steps
marcel merged pull request marcel/familienarchiv#715 2026-06-02 19:57:20 +02:00
devops: extract composite actions for obs stack deploy steps (#603)
marcel commented on issue marcel/familienarchiv#628 2026-06-02 19:51:51 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input

Implemented on feat/issue-628-mention-reedit

Re-edit affordance for saved @mentions landed via TDD (browser-only vitest-browser-svelte, verified by the --project=client CI lane).…

marcel pushed to feat/issue-628-mention-reedit at marcel/familienarchiv 2026-06-02 19:51:32 +02:00
4abda48965 feat(transcription): announce re-edit context via the existing live region (#628)
7f141725f8 test(transcription): AC-7 disabled, AC-8 no-mention, security clip/provenance (#628)
22205f50a2 test(transcription): AC-6 single-dropdown invariant + stale-fetch guard (#628)
9deaaae3e8 feat(transcription): dismiss + keyboard-operate the re-edit dropdown (#628 AC-4/AC-9)
02c95b9cfc feat(transcription): re-edit @mention via a pencil affordance (#628)
Compare 7 commits »
marcel created branch feat/issue-628-mention-reedit in marcel/familienarchiv 2026-06-02 19:51:32 +02:00
marcel commented on pull request marcel/familienarchiv#715 2026-06-02 19:51:12 +02:00
devops: extract composite actions for obs stack deploy steps (#603)

🔒 Nora Steiner — Security (re-review)

✅ Approved — both prior blockers withdrawn.

Honest about uncertainty, and honest when I was wrong. I was wrong. Here's the proof, run against…

marcel commented on pull request marcel/familienarchiv#715 2026-06-02 19:51:05 +02:00
devops: extract composite actions for obs stack deploy steps (#603)

🧪 Sara Holt — QA (re-review)

✅ Approved — both of my round-1 concerns are resolved; the remaining gap is an operational watch-item for the human, not a code blocker.

I re-pulled the…