marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#720 2026-06-02 20:54:55 +02:00
fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)

🎨 Leonie Voss — UI/UX Design Lead & Accessibility Advocate

Verdict: ✅ Approved

This is a clean, correct accessibility fix and it lands exactly where it should. I traced the geometry…

marcel commented on pull request marcel/familienarchiv#720 2026-06-02 20:54:34 +02:00
fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)

📋 Elicit — Requirements Engineer / Business Analyst

Verdict: ✅ Approved

I reviewed this PR strictly against the acceptance criteria in issue #718 — does the change satisfy every AC,…

marcel commented on pull request marcel/familienarchiv#720 2026-06-02 20:54:30 +02:00
fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

I reviewed this from an adversarial lens looking for injection, XSS, authorization, untrusted-input, and…

marcel commented on pull request marcel/familienarchiv#720 2026-06-02 20:54:19 +02:00
fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)

👨‍💻 Felix Brandt — Fullstack Developer

Verdict: ✅ Approved

Small, surgical, well-tested fix. I checked TDD evidence, the comparator's correctness/determinism, the Svelte 5 reactivity…

marcel commented on pull request marcel/familienarchiv#720 2026-06-02 20:54:17 +02:00
fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

LGTM from the infra/ops chair — nothing in my domain to flag. This is a pure frontend change: a $derived.by sort…

marcel commented on pull request marcel/familienarchiv#720 2026-06-02 20:53:48 +02:00
fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

I reviewed this purely through the architecture lens: layer boundaries, coupling, module responsibilities, separation of…

marcel created pull request marcel/familienarchiv#721 2026-06-02 20:53:28 +02:00
feat: Remove the Briefwechsel view; retarget its links to document search (#716)
marcel pushed to feat/issue-716-remove-briefwechsel at marcel/familienarchiv 2026-06-02 20:53:08 +02:00
36457f28ff docs(adr): record the bilateral->unidirectional search regression (ADR-030)
2fbd16db4d docs: remove Briefwechsel from architecture, routes and glossary
9c1107fdf6 chore(api): regenerate TS client without the conversation endpoint
8b7cbc5bd3 feat(document): remove conversation repository queries
55bc44b7ab feat(document): remove conversation service methods
Compare 10 commits »
marcel created branch feat/issue-716-remove-briefwechsel in marcel/familienarchiv 2026-06-02 20:53:08 +02:00
marcel created pull request marcel/familienarchiv#720 2026-06-02 20:52:32 +02:00
fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)
marcel commented on issue marcel/familienarchiv#716 2026-06-02 20:50:10 +02:00
feat: Remove the Briefwechsel view; retarget its links to document search

Implemented on feat/issue-716-remove-briefwechsel

The Briefwechsel view is fully removed (frontend + backend) and its one inbound link now deep-links into document search. Worked grep-driven…

marcel commented on issue marcel/familienarchiv#718 2026-06-02 20:32:34 +02:00
[bug] Stammbaum keyboard tab order is unpredictable — follows DB order, not visual layout

Implemented ✅

Tab order now follows the visual reading order instead of backend/DB row order.

Branch: feat/issue-718-stammbaum-tab-order (off main) Commit: eab4153b —…

marcel pushed to feat/issue-718-stammbaum-tab-order at marcel/familienarchiv 2026-06-02 20:32:21 +02:00
eab4153b97 fix(stammbaum): order keyboard tab stops by visual layout, not DB order (#718)
marcel created branch feat/issue-718-stammbaum-tab-order in marcel/familienarchiv 2026-06-02 20:32:20 +02:00
marcel commented on issue marcel/familienarchiv#560 2026-06-02 20:29:15 +02:00
Consolidate shared vi.mock bodies into __mocks__/ via sync factories + migrate confirm/notification specs to test-fixtures

Implemented in PR #719 (branch feat/issue-560-shared-vimock-mocks, 14 ordered commits, rebased onto current main).

Re-grepped counts (the 2026-06-02 snapshot had drifted): confirm…

marcel created pull request marcel/familienarchiv#719 2026-06-02 20:28:54 +02:00
Consolidate shared vi.mock bodies + migrate confirm/notification specs (#560)
marcel pushed to feat/issue-560-shared-vimock-mocks at marcel/familienarchiv 2026-06-02 20:28:24 +02:00
140b321868 refactor(notification): provide notification store via context + fixture
13c6b7d27f test: inject real ConfirmService via context (batch 2/2)
a4d4ff35d9 test: inject real ConfirmService via context (batch 1/2)
e5cf98e1d4 test(hooks): migrate useUnsavedWarning spec to shared $app/navigation mock
cc76d4de91 test(mocks): add shared $app/navigation mock with simulateNavigate
Compare 10 commits »
marcel created branch feat/issue-560-shared-vimock-mocks in marcel/familienarchiv 2026-06-02 20:28:23 +02:00
marcel commented on pull request marcel/familienarchiv#717 2026-06-02 20:23:13 +02:00
feat(transcription): re-edit existing @mention by pre-filling the search input (#628)

CI: server coverage gate fixed (commit e6a0fbc9)

The "unit and component tests with coverage" step failed on the coverage threshold (functions 78.68%, branches 78.48% < 80%) — not…

marcel pushed to feat/issue-628-mention-reedit at marcel/familienarchiv 2026-06-02 20:22:44 +02:00
e6a0fbc915 test(frontend): exclude mentionNodeView from server coverage (#628)