marcel

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:51:01 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

⚙️ Tobias Wendt — DevOps (re-review)

⚠️ **Approved — all three of my prior concerns resolved; the only open item is the still-pending live workflow_dispatch run, which keeps this at ⚠️…

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:50:44 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

🏛️ Markus Keller — Architect (re-review)

✅ Approved — concerns from round 1 cleared; the heredoc CI guard sits at the right layer and matches the established ADR-driven precedent. No…

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:50:35 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

👨‍💻 Felix Brandt — Senior Fullstack Developer (re-review)

✅ Approved — my concern is fully resolved. The unquoted-heredoc invariant now has a structural CI guard built in the repo's…

marcel opened issue marcel/familienarchiv#716

2026-06-02 19:48:01 +02:00

feat: Remove the Briefwechsel view; retarget its links to document search

marcel pushed to feat/issue-603-composite-deploy-actions at marcel/familienarchiv

2026-06-02 19:41:10 +02:00

03e2615fa7 ci(deploy): use ::error:: annotations for smoke-test failures

3db6a3bf8f ci(deploy): correct stale POSTGRES_HOST --env-file comment

Compare 2 commits »

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:38:57 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

Review resolution

Thanks all. Addressed below; two new commits pushed.

🔒 Nora's blocker (unquoted-heredoc secret mangling) — verified as a non-issue

The claim that <<EOF + $VAR…

marcel pushed to feat/issue-603-composite-deploy-actions at marcel/familienarchiv

2026-06-02 19:38:39 +02:00

0e06626eef ci(deploy): guard deploy-obs heredoc stays unquoted (#603)

a47564934d ci(deploy): harden deploy-obs config step with set -euo pipefail

Compare 2 commits »

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:33:37 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

DevOps & Platform review — Tobias Wendt (@tobiwendt)

⚠️ Approved with concerns — the refactor is structurally correct and behaviour-preserving on every axis I could verify statically.…

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:33:16 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

QA Review — Sara Holt (@saraholt), Senior QA Engineer

⚠️ Approved with concerns.

The refactor is clean and behaviour-preserving on inspection, and the security ordering (guard-then-`chmo…

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:32:58 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

👨‍💻 Felix Brandt — Senior Fullstack Developer

⚠️ Approved with concerns. This is a genuinely clean DRY refactor — the duplication is gone, the per-environment variance is a typed…

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:32:58 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

Nora "NullX" Steiner — Application Security Engineer · Ethical Hacker

Adversarial mindset, defender's heart. I'll name the exact line and the exact payload, and hand you the fix in the same…

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:32:46 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

Requirements Engineering review — "Elicit"

Verdict: ✅ Approved

A clean, behaviour-preserving refactor with full requirements→implementation traceability. I traced every acceptance…

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:32:23 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

Leonie Voss (@leonievoss) — UI/UX & Accessibility

✅ Approved — not applicable to my domain.

I scanned all 8 changed files. This is a pure CI/infrastructure refactor with **zero…

marcel commented on pull request marcel/familienarchiv#715

2026-06-02 19:32:16 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

🏛️ Markus Keller — Architect

✅ Approved with concerns (concerns are suggestions, not blockers).

I reviewed this through the lens I care about: module boundaries, coupling, single-respon…

marcel closed issue marcel/familienarchiv#239

2026-06-02 19:28:31 +02:00

devops: add docker-compose.prod.yml overlay for production deployment

marcel closed issue marcel/familienarchiv#86

2026-06-02 19:27:19 +02:00

fix(security): set secure: true on auth cookie for production (HTTPS)

marcel commented on issue marcel/familienarchiv#603

2026-06-02 19:26:36 +02:00

devops: extract composite action for obs stack deploy steps

Implemented in PR #715 (feat/issue-603-composite-deploy-actions).

Commits (8, atomic):

b0d28c1e ci(deploy): extract reload-caddy composite action
a6a8552a ci(deploy): extract…

marcel created pull request marcel/familienarchiv#715

2026-06-02 19:26:22 +02:00

devops: extract composite actions for obs stack deploy steps (#603)

marcel pushed to feat/issue-603-composite-deploy-actions at marcel/familienarchiv

2026-06-02 19:26:04 +02:00

02fb16a0bd docs(ci): document composite actions in ci-gitea.md

4757a174c9 docs(adr): add ADR-029 composite actions for cross-workflow deploy logic

75293c6aa8 ci(deploy): extend Renovate privileged-digest watch to .gitea/actions

4e9b13c0e4 ci(deploy): wire release.yml to composite deploy actions

ad27c1f757 ci(deploy): wire nightly.yml to composite deploy actions

Compare 8 commits »

marcel created branch feat/issue-603-composite-deploy-actions in marcel/familienarchiv

2026-06-02 19:26:04 +02:00