marcel

0 Followers · 0 Following

• Joined on 2026-03-17

Repositories

3

Projects Packages Public Activity Starred Repositories

marcel pushed to feat/issue-708-pdfjs-wasmurl at marcel/familienarchiv 2026-06-01 21:12:27 +02:00

e16b7402bd fix(document): make the PDF error state accessible (alert + larger link)

229c1b0539 test(document): exercise the real render-failure path in PdfViewer test

f24c415b04 fix(document): localize loadDocument error too — no raw pdf.js text

4c57a2262f test(frontend): guard wasm shipping at build time, drop CI-fragile pixel test

b8e01f997d docs(caddy): note future CSP must allow wasm-unsafe-eval for pdf.js

Compare 16 commits »

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:49:45 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Elicit — Requirements Engineer & Business Analyst (re-review)

⚠️ Approved with concerns (Brownfield — Phase B4 Gap Analysis lens)

I check the PR against #708's acceptance criteria…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:49:26 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Leonie Voss — UI/UX Design Lead & Accessibility Advocate (re-review)

⚠️ Approved with concerns

The 2c967523 commit addressed most of what I flagged for the senior read journey.…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:49:10 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Tobias Wendt — DevOps & Platform Engineer (re-review)

✅ Approved

My two blockers were about build/prod parity being enforced by the pipeline, not by a reviewer's curl. Both are now…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:48:55 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Nora "NullX" Steiner — Application Security Engineer (re-review)

✅ Approved

No blockers from me in the first round; my two suggestions were both security-relevant. Status:

###…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:48:34 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Sara Holt — QA Engineer & Test Strategist (re-review)

⚠️ Approved with concerns (was 🚫)

I own the test pyramid here. The author made a significant strategy change — and I largely…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:48:16 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Felix Brandt — Senior Fullstack Developer (re-review)

✅ Approved

Both of my blockers are resolved, verified against the head branch.

Blocker 1 — raw error leak on the load path…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:48:03 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Markus Keller — Application Architect (re-review)

⚠️ Approved with concerns

I verified the new commits against the actual diff and head branch.

My prior blockers

1. **ADR for…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:46:20 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

🔧 Re-review fixes pushed (23a635e0..2c967523)

Addressed the valid blockers from the first round. Also: the behavioral pixel test failed in CI (green locally, blank canvas in CI — the…

marcel pushed to feat/issue-708-pdfjs-wasmurl at marcel/familienarchiv 2026-06-01 20:46:03 +02:00

2c96752330 fix(document): make the PDF error state accessible (alert + larger link)

1d2c529436 test(document): exercise the real render-failure path in PdfViewer test

2a44bc33fe fix(document): localize loadDocument error too — no raw pdf.js text

23a635e0fb test(frontend): guard wasm shipping at build time, drop CI-fragile pixel test

Compare 4 commits »

marcel deleted branch feat/issue-710-remove-originaltext from marcel/familienarchiv 2026-06-01 20:35:42 +02:00

marcel pushed to main at marcel/familienarchiv 2026-06-01 20:35:41 +02:00

8a1cc2d1f0 chore(i18n): drop the unused date_original_label key and stale comments

d5bf401085 feat(document): stop surfacing the raw cell in the detail drawer

4944918692 feat(document): remove the visible Originaltext line from DocumentDate

bf90427bfa feat(document): drop the read-only Originaltext field from the edit form

Compare 4 commits »

marcel closed issue marcel/familienarchiv#710 2026-06-01 20:35:40 +02:00

Remove the read-only "Originaltext" date field that confuses editors

marcel merged pull request marcel/familienarchiv#712 2026-06-01 20:35:40 +02:00

Remove the read-only "Originaltext" date field that confuses editors (#710)

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:23:57 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Elicit — Requirements Engineer & Business Analyst

⚠️ Approved with concerns (Brownfield — Phase B4 Gap Analysis lens)

I don't review code; I check the PR against the acceptance…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:23:31 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Leonie Voss — UI/UX Design Lead & Accessibility Advocate

⚠️ Approved with concerns

This fix directly serves the read journey for the senior audience — the people most likely to be…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:23:10 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Tobias Wendt — DevOps & Platform Engineer

⚠️ Approved with concerns

I reviewed this for build/prod parity, dependency footprint, and whether the wasm actually ships in the real…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:22:44 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Nora "NullX" Steiner — Application Security Engineer

⚠️ Approved with concerns

I reviewed the new attack surface this introduces: a self-served wasm asset path, the CWE-1022…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:22:26 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Sara Holt — QA Engineer & Test Strategist

🚫 Changes requested

I own the test pyramid for this change and I have real concerns about whether the behavioral fixture test is the…

marcel commented on pull request marcel/familienarchiv#713 2026-06-01 20:22:00 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Felix Brandt — Senior Fullstack Developer

⚠️ Approved with concerns

I read this for TDD discipline, naming, guard clauses, dead code, and Svelte 5 correctness. The core change in…