marcel

marcel commented on pull request marcel/familienarchiv#713

2026-06-01 20:21:42 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

👤 Markus Keller — Application Architect

⚠️ Approved with concerns

I reviewed this for accidental complexity, layer boundaries, transport/asset-serving choices, and — most importantly…

marcel commented on issue marcel/familienarchiv#708

2026-06-01 20:19:49 +02:00

[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

✅ Implemented — PR #713

Branch feat/issue-708-pdfjs-wasmurl (worktree off main). TDD red→green, 8 atomic commits:

marcel created pull request marcel/familienarchiv#713

2026-06-01 20:19:24 +02:00

fix(document): configure pdf.js wasmUrl so CCITT/JBIG2 scans stop rendering blank (#708)

marcel pushed to feat/issue-708-pdfjs-wasmurl at marcel/familienarchiv

2026-06-01 20:19:02 +02:00

688d38120a docs(caddy): note future CSP must allow wasm-unsafe-eval for pdf.js

cf86019337 test(document): behavioral CCITT/DCT render fixtures prove the wasm path

6690e1374d fix(document): add rel=noopener noreferrer to viewer download link (CWE-1022)

e0eedc70f9 fix(document): localize PdfViewer render-error message and download link

aa1e89c290 fix(document): surface PDF render failures instead of a silent blank canvas

Compare 8 commits »

marcel created branch feat/issue-708-pdfjs-wasmurl in marcel/familienarchiv

2026-06-01 20:19:02 +02:00

marcel commented on pull request marcel/familienarchiv#712

2026-06-01 20:14:02 +02:00

Remove the read-only "Originaltext" date field that confuses editors (#710)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved (LGTM)

Nothing in my domain to flag. I checked the diff for anything operational and found none:

**No infrastructure…

marcel commented on pull request marcel/familienarchiv#712

2026-06-01 20:13:56 +02:00

Remove the read-only "Originaltext" date field that confuses editors (#710)

📋 "Elicit" — Requirements Engineer / Business Analyst (Brownfield)

Verdict: ✅ Approved

This PR has an unusually clean requirements trace, which is exactly what I look for in a…

marcel commented on pull request marcel/familienarchiv#712

2026-06-01 20:13:43 +02:00

Remove the read-only "Originaltext" date field that confuses editors (#710)

🎨 Leonie Voss — UX & Accessibility Lead

Verdict: ✅ Approved

Removing the "Originaltext:" line is the right UX call. For our dual audience — and especially the 60+ transcribers — a…

marcel commented on pull request marcel/familienarchiv#712

2026-06-01 20:13:30 +02:00

Remove the read-only "Originaltext" date field that confuses editors (#710)

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

The test changes are well-structured and the deletions are defensible, but I want to be precise about what…

marcel commented on pull request marcel/familienarchiv#712

2026-06-01 20:13:15 +02:00

Remove the read-only "Originaltext" date field that confuses editors (#710)

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

This PR removes attack surface, it does not add any. From a security standpoint it's a net improvement, and…

marcel commented on pull request marcel/familienarchiv#712

2026-06-01 20:13:00 +02:00

Remove the read-only "Originaltext" date field that confuses editors (#710)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

This is a frontend-only presentation-layer cleanup with no module-boundary, transport, schema, or data-flow implications.…

marcel commented on pull request marcel/familienarchiv#712

2026-06-01 20:12:50 +02:00

Remove the read-only "Originaltext" date field that confuses editors (#710)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Clean, focused deletion. The PR does exactly what it says: it removes a confusing UI element and its round-trip input…

marcel commented on issue marcel/familienarchiv#710

2026-06-01 20:11:45 +02:00

Remove the read-only "Originaltext" date field that confuses editors

Implemented in PR #712 (branch feat/issue-710-remove-originaltext, worktree-based on main, TDD).

Commits

914eadf3 feat(document): drop the read-only Originaltext field from the edit…

marcel created pull request marcel/familienarchiv#712

2026-06-01 20:11:31 +02:00

Remove the read-only "Originaltext" date field that confuses editors (#710)

marcel pushed to feat/issue-710-remove-originaltext at marcel/familienarchiv

2026-06-01 20:11:13 +02:00

8a1cc2d1f0 chore(i18n): drop the unused date_original_label key and stale comments

d5bf401085 feat(document): stop surfacing the raw cell in the detail drawer

4944918692 feat(document): remove the visible Originaltext line from DocumentDate

bf90427bfa feat(document): drop the read-only Originaltext field from the edit form

Compare 4 commits »

marcel created branch feat/issue-710-remove-originaltext in marcel/familienarchiv

2026-06-01 20:11:12 +02:00

marcel deleted branch feat/issue-709-remove-density-cache-ttl from marcel/familienarchiv

2026-06-01 20:01:34 +02:00

marcel pushed to main at marcel/familienarchiv

2026-06-01 20:01:33 +02:00

50f554680c refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)

marcel closed issue marcel/familienarchiv#709

2026-06-01 20:01:32 +02:00

Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

marcel merged pull request marcel/familienarchiv#711

2026-06-01 20:01:32 +02:00

refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)