• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#711 2026-06-01 19:59:52 +02:00
refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: Approved

This is a backend-only change with no markup, styling, or component diff — so there is nothing for me to…

marcel commented on pull request marcel/familienarchiv#711 2026-06-01 19:59:43 +02:00
refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)

📋 Elicit — Requirements Engineer & Business Analyst

Verdict: ⚠️ Approved with concerns

Working in Brownfield mode. I assessed this against the issue's acceptance criteria and the…

marcel commented on pull request marcel/familienarchiv#711 2026-06-01 19:59:25 +02:00
refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

I was cited in the issue as confirming there is no load reason to cache this at current scale, and nothing in the diff…

marcel commented on pull request marcel/familienarchiv#711 2026-06-01 19:59:16 +02:00
refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

The change is correct and the test was updated red-first, which I appreciate. My concerns are about test layer and…

marcel commented on pull request marcel/familienarchiv#711 2026-06-01 19:58:59 +02:00
refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)

🏛️ Markus Keller — Application Architect

Verdict: Approved

A small, correct refactor that pushes a caching decision to where it belongs and documents the why. No layering or…

marcel commented on pull request marcel/familienarchiv#711 2026-06-01 19:58:46 +02:00
refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved

This change is a net security improvement, and I want to give credit for that explicitly.

Security…

marcel commented on pull request marcel/familienarchiv#711 2026-06-01 19:58:33 +02:00
refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: Approved

I reviewed this through the clean-code and TDD lens. It is a small, disciplined refactor and it reads correctly.

###…

marcel commented on issue marcel/familienarchiv#709 2026-06-01 19:57:33 +02:00
Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

Implemented — PR #711

Worked the resolved decision (remove the explicit header, always-fresh) via red/green TDD on branch feat/issue-709-remove-density-cache-ttl.

Commit: 50f5546

marcel created pull request marcel/familienarchiv#711 2026-06-01 19:57:13 +02:00
refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)
marcel pushed to feat/issue-709-remove-density-cache-ttl at marcel/familienarchiv 2026-06-01 19:57:00 +02:00
50f554680c refactor(document): drop the 5-minute Cache-Control TTL on /density (#709)
marcel created branch feat/issue-709-remove-density-cache-ttl in marcel/familienarchiv 2026-06-01 19:57:00 +02:00
marcel commented on issue marcel/familienarchiv#708 2026-06-01 19:52:46 +02:00
[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

Decisions resolved + blast radius measured

The three open decisions are resolved with best-practice defaults and folded into the issue body:

  1. wasm shipping → vite-plugin-static-copy
marcel opened issue marcel/familienarchiv#710 2026-06-01 19:49:31 +02:00
Remove the read-only "Originaltext" date field that confuses editors
marcel commented on issue marcel/familienarchiv#708 2026-06-01 19:43:03 +02:00
[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

🗳️ Decision Queue — Action Required

3 decisions need your input before implementation starts. Everything else is concrete recommendation — no need to respond to it.

Build /…

marcel commented on issue marcel/familienarchiv#708 2026-06-01 19:42:43 +02:00
[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

📋 Elicit — Requirements Engineer / Business Analyst

Observations

  • The issue is unusually well-evidenced (codec table, file paths, source line refs) — that's the right altitude for our…
marcel commented on issue marcel/familienarchiv#708 2026-06-01 19:42:24 +02:00
[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

🔧 Tobias Wendt — DevOps & Platform Engineer

Observations

  • The whole bug is a dev/prod asset-resolution gap, which is my territory. Production runs node build from `frontend/Dockerf…
marcel commented on issue marcel/familienarchiv#708 2026-06-01 19:42:03 +02:00
[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

🎨 Leonie Voss — UI/UX Design Lead & Accessibility Advocate

Observations

  • The cruelest part of this bug for our users: a blank white viewer with no explanation. A 67-year-old family…
marcel commented on issue marcel/familienarchiv#709 2026-06-01 19:41:54 +02:00
Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

🗳️ Decision Queue — Action Required

2 decisions need your input before implementation starts.

Product / Data freshness

  • **What staleness window (N) is acceptable for the density…
marcel commented on issue marcel/familienarchiv#708 2026-06-01 19:41:46 +02:00
[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

🧪 Sara Holt — QA Engineer & Test Strategist

Observations

  • The bug's signature is dev-passes / prod-fails: it only manifests in the browser modern build with assets served over HTTP.…
marcel commented on issue marcel/familienarchiv#709 2026-06-01 19:41:38 +02:00
Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

📋 Elicit — Requirements Engineer

Observations

  • The issue is well-structured (context, problem, candidate options, scoped ACs, pointers) — this is a healthy, refinement-ready ticket.…