marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#170 2026-03-31 16:19:23 +02:00
feat(focus-rings): branded focus ring tokens (#167)

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

The test-first commit (fe1121d) is there, which I appreciate. The tests are at the correct layer (E2E/Playwright for CSS…

marcel commented on pull request marcel/familienarchiv#170 2026-03-31 16:19:00 +02:00
feat(focus-rings): branded focus ring tokens (#167)

🏗️ Markus Keller — Application Architect

Verdict: ✅ Approved

This is a textbook design token migration: single source of truth, clear naming, correct layer placement, no business logic…

marcel commented on pull request marcel/familienarchiv#170 2026-03-31 16:18:49 +02:00
feat(focus-rings): branded focus ring tokens (#167)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: 🚫 Changes requested

Blockers

**ConversationFilterBar.svelte (both /conversations/ and /korrespondenz/) — broken…

marcel commented on issue marcel/familienarchiv#167 2026-03-31 16:11:48 +02:00
feat(focus-rings): branded focus ring tokens for light and dark mode

Implementation complete ✅

All 8 tasks implemented on branch feat/issue-167-focus-ring-tokens → PR #170.

What was done

Token + global rule

  • --c-focus-ring: #012851 (light) /…
marcel created pull request marcel/familienarchiv#170 2026-03-31 16:11:31 +02:00
feat(focus-rings): branded focus ring tokens (#167)
marcel pushed to feat/issue-167-focus-ring-tokens at marcel/familienarchiv 2026-03-31 16:09:31 +02:00
f1bf32ee05 feat(focus-rings): CommentThread selection highlight → dotted outline
a5cc8fd16e feat(focus-rings): update interactive widgets to ring-focus-ring
1541afd470 feat(focus-rings): update all form inputs and document components to ring-focus-ring
d0deb26065 feat(focus-rings): update auth and search inputs to ring-focus-ring
f04e4ffa8b feat(focus-rings): update header/nav components to ring-focus-ring
Compare 7 commits »
marcel created branch feat/issue-167-focus-ring-tokens in marcel/familienarchiv 2026-03-31 16:09:30 +02:00
marcel deleted branch feat/issue-166-dark-mode-navy-palette from marcel/familienarchiv 2026-03-31 14:14:49 +02:00
marcel pushed to main at marcel/familienarchiv 2026-03-31 14:14:42 +02:00
2004a80055 fix(a11y): UserMenu avatar bg-white/text-brand-navy — WCAG AA contrast
marcel merged pull request marcel/familienarchiv#169 2026-03-31 14:14:40 +02:00
fix(a11y): UserMenu avatar bg-white/text-brand-navy — WCAG AA contrast
marcel created pull request marcel/familienarchiv#169 2026-03-31 14:14:26 +02:00
fix(a11y): UserMenu avatar bg-white/text-brand-navy — WCAG AA contrast
marcel commented on pull request marcel/familienarchiv#168 2026-03-31 14:13:18 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA

🎨 Leonie Voss — UI/UX Design Lead · Discussion summary

Three open items from my review comment worked through with the product owner.

Resolved

**1. Accent stripe (h-1 bg-accent in…

marcel pushed to feat/issue-166-dark-mode-navy-palette at marcel/familienarchiv 2026-03-31 14:08:58 +02:00
2004a80055 fix(a11y): UserMenu avatar bg-white/text-brand-navy — WCAG AA contrast
marcel created branch feat/issue-166-dark-mode-navy-palette in marcel/familienarchiv 2026-03-31 14:08:57 +02:00
marcel deleted branch feat/issue-166-dark-mode-navy-palette from marcel/familienarchiv 2026-03-31 13:54:03 +02:00
marcel pushed to main at marcel/familienarchiv 2026-03-31 13:53:44 +02:00
f70b5ae6bd fix(dark-mode): address PR #168 review blockers
12b8324245 chore: merge main into feat/issue-166 — resolve blue header conflicts
a9b648454e fix(dark-mode): use bg-header on layout header; set --c-header to brand-navy
938a4b07bf test(dark-mode): add failing test for --c-header token on header element
7e43bd43a4 feat(dark-mode): replace neutral tokens with navy-tinted palette + fix WCAG AA
Compare 7 commits »
marcel closed issue marcel/familienarchiv#166 2026-03-31 13:53:43 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure
marcel merged pull request marcel/familienarchiv#168 2026-03-31 13:53:42 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA
marcel commented on pull request marcel/familienarchiv#168 2026-03-31 13:34:11 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA

👨‍💻 Felix Brandt — Review blockers addressed (f70b5ae)

Blockers resolved

1. AuthHeader.svelte — bg-brand-navy → bg-header (Felix + Leonie)

Fixed. The header now uses the…

marcel pushed to feat/issue-166-dark-mode-navy-palette at marcel/familienarchiv 2026-03-31 13:31:00 +02:00
f70b5ae6bd fix(dark-mode): address PR #168 review blockers