marcel

marcel commented on pull request marcel/familienarchiv#168

2026-03-31 13:15:11 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

Pure frontend styling change. Nothing in the CI pipeline, Docker Compose, or deployment infrastructure is touched.

…

marcel commented on pull request marcel/familienarchiv#168

2026-03-31 13:15:06 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ⚠️ Approved with concerns

The core palette work is excellent — navy-tinted dark tokens are exactly what this project needed, and the WCAG AA…

marcel commented on pull request marcel/familienarchiv#168

2026-03-31 13:14:44 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

This PR is a CSS token replacement and Svelte component styling update. The attack surface delta is…

marcel commented on pull request marcel/familienarchiv#168

2026-03-31 13:14:36 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

Good test pyramid coverage for the core feature. TDD discipline is visible in the commit history. A few gaps worth…

marcel commented on pull request marcel/familienarchiv#168

2026-03-31 13:14:20 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

This is a well-contained, frontend-only change. No cross-layer leaks, no backend involvement, no new dependencies. The…

marcel commented on pull request marcel/familienarchiv#168

2026-03-31 13:14:08 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

TDD evidence is solid — the commit history shows failing tests before implementation (`test(dark-mode)…

marcel pushed to feat/issue-166-dark-mode-navy-palette at marcel/familienarchiv

2026-03-31 12:25:24 +02:00

12b8324245 chore: merge main into feat/issue-166 — resolve blue header conflicts

2dd73cf594 test(LanguageSwitcher): add Vitest unit tests for inverted prop

53038dea68 fix(header): address PR review blockers

281934529e fix(header): consistent icon styling, focus rings, and responsive breakpoints

c905f136d2 test(header): add Playwright tests for brand-navy header

Compare 13 commits »

marcel created pull request marcel/familienarchiv#168

2026-03-31 12:03:29 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA

marcel pushed to feat/issue-166-dark-mode-navy-palette at marcel/familienarchiv

2026-03-31 12:00:29 +02:00

a9b648454e fix(dark-mode): use bg-header on layout header; set --c-header to brand-navy

938a4b07bf test(dark-mode): add failing test for --c-header token on header element

7e43bd43a4 feat(dark-mode): replace neutral tokens with navy-tinted palette + fix WCAG AA

56926efd03 test(a11y): add dark mode axe + color-scheme tests for issue #166

a6ee444f3b docs(specs): add focus rings design spec for issue #167

Compare 5 commits »

marcel created branch feat/issue-166-dark-mode-navy-palette in marcel/familienarchiv

2026-03-31 12:00:26 +02:00

marcel commented on issue marcel/familienarchiv#166

2026-03-31 12:00:01 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

✅ Felix Brandt — Implementation Complete

Branch: feat/issue-166-dark-mode-navy-palette

What was implemented

4 commits, all TDD (red → green → commit):

marcel deleted branch feat/issue-163-brand-navy-header from marcel/familienarchiv

2026-03-31 10:41:47 +02:00

marcel closed issue marcel/familienarchiv#163

2026-03-31 10:41:43 +02:00

feat(header): replace white header with brand-navy header per design spec

marcel pushed to main at marcel/familienarchiv

2026-03-31 10:41:43 +02:00

2dd73cf594 test(LanguageSwitcher): add Vitest unit tests for inverted prop

53038dea68 fix(header): address PR review blockers

281934529e fix(header): consistent icon styling, focus rings, and responsive breakpoints

c905f136d2 test(header): add Playwright tests for brand-navy header

36bf591afe feat(forgot-password): add AuthHeader for consistent auth page branding

Compare 12 commits »

marcel merged pull request marcel/familienarchiv#165

2026-03-31 10:41:42 +02:00

feat(header): replace white header with brand-navy header per design spec

marcel pushed to feat/issue-163-brand-navy-header at marcel/familienarchiv

2026-03-31 10:39:39 +02:00

2dd73cf594 test(LanguageSwitcher): add Vitest unit tests for inverted prop

53038dea68 fix(header): address PR review blockers

Compare 2 commits »

marcel commented on issue marcel/familienarchiv#167

2026-03-31 10:38:19 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

🚀 Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

This is a pure frontend CSS change — no infra, no config, no deployment concerns. But a few pipeline observations:

…

marcel commented on issue marcel/familienarchiv#167

2026-03-31 10:38:02 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

🎨 Leonie Voss — UI/UX Design Lead

This issue is in my domain. The values and intent are right — a few things to tighten up before implementation.

Contrast values — good, with one…

marcel commented on issue marcel/familienarchiv#167

2026-03-31 10:37:39 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

🔐 Nora "NullX" Steiner — Application Security Engineer

Questions & Observations

No direct security vulnerabilities in this change — adding CSS custom properties and updating focus ring…

marcel commented on issue marcel/familienarchiv#167

2026-03-31 10:37:20 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

🧪 Sara Holt — QA Engineer & Test Strategist

Questions & Observations

The acceptance criteria say "verified with keyboard navigation" — who verifies and how? Manual keyboard…