marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel deleted branch feature/686-resolve-pdf-by-index from marcel/familienarchiv 2026-05-27 22:08:51 +02:00
marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-27 22:08:49 +02:00
0a3d12b9af docs: drop remaining stale MassImportService/ExcelService references
34e0eec1ba docs(adr): record the index pattern as a corpus-specific constraint
f5e2241fe0 test(importing): pin regex reject-boundary + note untestable IO branch
f96b9fbffc feat(importing): log import-row breadcrumbs and distinguish skip outcomes
a4c2b6289d docs: drop stale MassImportService/ODS references from import deploy docs
Compare 9 commits »
marcel closed issue marcel/familienarchiv#676 2026-05-27 22:08:47 +02:00
Importer file lookup walks the whole import dir per row (O(rows×tree))
marcel closed issue marcel/familienarchiv#686 2026-05-27 22:08:47 +02:00
As the archive owner I want import PDFs resolved directly by index (e.g. W-0124.pdf), dropping the file column
marcel merged pull request marcel/familienarchiv#687 2026-05-27 22:08:47 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)
marcel pushed to feature/686-resolve-pdf-by-index at marcel/familienarchiv 2026-05-27 21:30:47 +02:00
ea38efc734 docs: drop remaining stale MassImportService/ExcelService references
marcel deleted branch feature/668-undated-documents from marcel/familienarchiv 2026-05-27 21:26:52 +02:00
marcel merged pull request marcel/familienarchiv#682 2026-05-27 21:26:51 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)
marcel closed issue marcel/familienarchiv#668 2026-05-27 21:26:51 +02:00
As a reader I want undated and imprecisely-dated letters to be honestly labelled in browse views so I always understand a document's date position
marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-27 21:26:51 +02:00
7183d15fe5 fix(document): restore pure-text-relevance FTS fast path past undated count
b52bf60913 fix(document): tie-break equal-date DATE sort by title asc, not createdAt
45e63307bb fix(documents): give the undated count chip a self-describing a11y name
995471082e test(documents): update obsolete em-dash assertion to undated badge
c6137a26a2 feat(documents): show global undated count chip on the filter toggle
Compare 19 commits »
marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:24:53 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Leonie Voss — UX Designer & Accessibility Strategist

Verdict: Approved (no UI surface)

I checked for any user-facing change: Svelte components/routes, brand tokens, accessibility,…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:24:46 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Elicit — Requirements Engineer & Business Analyst

Verdict: Approved

Brownfield requirements lens: does the change satisfy the intent of #686/#676, are the unhappy paths specified, and is…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:24:30 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

I reviewed the infrastructure-facing surface: the IMPORT_HOST_DIR mount contract, the compose/docs wording, and operability…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:24:16 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Sara Holt — Senior QA Engineer

Verdict: Approved with concerns

Test-strategy and coverage review. I assessed by reading the suite (full backend sweep is CI-only on this project); the…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:24:02 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Felix Brandt — Senior Fullstack Developer

Verdict: Approved

Clean-code and TDD review of the Java importer and the Python normalizer changes.

Naming and structure

  • resolveFile/`ba…
marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:23:45 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved

This is a CWE-22 (path traversal) review of the new index-driven resolution. I read the full DocumentImporter on…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:23:26 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Markus Keller — Senior Application Architect

Verdict: Approved with concerns

I reviewed the structural and data-model impact of resolving PDFs by index and dropping the file column,…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:21:19 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Felix Brandt — fixes for the "Approved with concerns" review

All non-blocking concerns from the review round are now addressed on feature/686-resolve-pdf-by-index (3 atomic commits on top…

marcel pushed to feature/686-resolve-pdf-by-index at marcel/familienarchiv 2026-05-27 21:20:28 +02:00
7354c3d332 docs(adr): record the index pattern as a corpus-specific constraint
b3f4fb2d8d test(importing): pin regex reject-boundary + note untestable IO branch
a1f96f60ac feat(importing): log import-row breadcrumbs and distinguish skip outcomes
Compare 3 commits »
marcel pushed to feature/686-resolve-pdf-by-index at marcel/familienarchiv 2026-05-27 21:14:40 +02:00
b1e83437ae docs: drop stale MassImportService/ODS references from import deploy docs