• Joined on 2026-03-17
marcel pushed to feature/686-resolve-pdf-by-index at marcel/familienarchiv 2026-05-27 21:20:28 +02:00
7354c3d332 docs(adr): record the index pattern as a corpus-specific constraint
b3f4fb2d8d test(importing): pin regex reject-boundary + note untestable IO branch
a1f96f60ac feat(importing): log import-row breadcrumbs and distinguish skip outcomes
Compare 3 commits »
marcel pushed to feature/686-resolve-pdf-by-index at marcel/familienarchiv 2026-05-27 21:14:40 +02:00
b1e83437ae docs: drop stale MassImportService/ODS references from import deploy docs
marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:13:55 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Leonie Voss — UX Designer & Accessibility Strategist

Verdict: Approved (LGTM — nothing in my domain)

I reviewed for anything touching the user-facing surface: Svelte components, routes,…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:13:45 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

"Elicit" — Requirements Engineer & Business Analyst

Verdict: Approved with concerns

I review this against the requirement behind it, not the implementation. The PR body frames it well:…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:13:29 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

No Compose, CI, Caddyfile, or secrets changes in this PR — but it changes the **operational contract for the import…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:13:15 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Felix Brandt — Senior Fullstack Developer

Verdict: Approved with concerns

I read DocumentImporter in full plus all the diffs. The TDD evidence is there (tests rewritten alongside the…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:12:53 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Markus Keller — Application Architect

Verdict: Approved

This is the right call. Removing the file column and the recursive walk replaces an O(rows×tree) traversal with an O(1)…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:12:38 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Sara Holt — Senior QA Engineer

Verdict: Approved with concerns

I assessed by reading (the backend suite + browser tests are CI-only here) and cross-checked the ported test set against…

marcel commented on pull request marcel/familienarchiv#687 2026-05-27 21:12:20 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)

Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved with concerns

This is the review I care about most: a CWE-22 path-traversal surface is being narrowed, not…

marcel created pull request marcel/familienarchiv#687 2026-05-27 21:06:40 +02:00
feat(import): resolve PDFs directly by index, drop the file column (#686)
marcel pushed to feature/686-resolve-pdf-by-index at marcel/familienarchiv 2026-05-27 21:06:01 +02:00
74987062f4 docs(import): document index-based PDF resolution in ADR-025 and DEPLOYMENT
508a5e555e chore(normalizer): regenerate canonical-documents.xlsx without file column
4d55eee5c8 feat(importing): resolve import PDFs directly by index
09ba7e74e3 refactor(normalizer): drop file column now PDFs resolve by index
Compare 4 commits »
marcel created branch feature/686-resolve-pdf-by-index in marcel/familienarchiv 2026-05-27 21:06:01 +02:00
marcel commented on pull request marcel/familienarchiv#682 2026-05-27 21:05:15 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Backend FTS regression fixed (6 failing relevance tests)

Root cause: The global undated-count change moved the pure-text-RELEVANCE shortcut out of the top of searchDocuments and into the…

marcel pushed to feature/668-undated-documents at marcel/familienarchiv 2026-05-27 21:04:54 +02:00
7183d15fe5 fix(document): restore pure-text-relevance FTS fast path past undated count
marcel opened issue marcel/familienarchiv#686 2026-05-27 20:47:51 +02:00
As the archive owner I want import PDFs resolved directly by index (<index>.pdf), dropping the file column
marcel commented on pull request marcel/familienarchiv#682 2026-05-27 20:21:35 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Owner-decided change: the equal-date secondary sort (tiebreaker) on the DATE sort path is now title ascending instead of createdAt ascending.

Result: `ORDER BY meta_date

NULLS LAST,…

marcel pushed to feature/668-undated-documents at marcel/familienarchiv 2026-05-27 20:21:25 +02:00
b52bf60913 fix(document): tie-break equal-date DATE sort by title asc, not createdAt
marcel closed issue marcel/familienarchiv#680 2026-05-27 20:13:24 +02:00
CI: guard against generated frontend api.ts drift
marcel opened issue marcel/familienarchiv#685 2026-05-27 19:58:59 +02:00
Cleanup path for confirmed persons that have no usable name
marcel opened issue marcel/familienarchiv#684 2026-05-27 19:58:53 +02:00
Move person-delete FK detach to database-level ON DELETE